Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move system information plugin to npm #6105

Merged

Conversation

kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Feb 19, 2020

Impact: minor
Type: refactor

This PR removes the system-info plugin code from the API, and installs the @reactioncommerce/plugin-system-information to perform the same functions.

Breaking changes

None

Testing

The system information code is the same as it was before, it's just being installed from a different place, so you should see nothing different in the behavior of this PR and the v3.1.0 release it was created from.

  1. Start the API
  2. Create a user
  3. Create a shop
  4. Use the systemInformation GraphQL query to query system information
{
systemInformation(shopId: "SHOP_ID") {
  plugins {
    version
    name
  }
  apiVersion
  mongoVersion {
    version
  }
}
}
  1. See system information

Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, just a minor comment.

package.json Outdated Show resolved Hide resolved
Signed-off-by: Erik Kieckhafer <[email protected]>
@kieckhafer
Copy link
Member Author

@willopez comment addressed

Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants